Get the error message from 'msg' key if 'error_message' doesn't exist.#12
Open
flyte wants to merge 1 commit intoshaunduncan:masterfrom
Open
Get the error message from 'msg' key if 'error_message' doesn't exist.#12flyte wants to merge 1 commit intoshaunduncan:masterfrom
flyte wants to merge 1 commit intoshaunduncan:masterfrom
Conversation
Contributor
Author
|
Hey @shaunduncan did you spot this PR? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you try to upload a file (such as a .webm) that Giphy doesn't support, you currently receive the following traceback:
This is because the response from Giphy looks like this:
I'm not sure whether Giphy ever sends back
error_messageas opposed tomsgas seen here but this patch tries both. Perhapserror_messagecan be removed if it's no longer used.After this patch it'll look something like this: