Use Daggers eager API with (vendored) lazy trees#80
Draft
DrChainsaw wants to merge 1 commit intoshashi:masterfrom
Draft
Use Daggers eager API with (vendored) lazy trees#80DrChainsaw wants to merge 1 commit intoshashi:masterfrom
DrChainsaw wants to merge 1 commit intoshashi:masterfrom
Conversation
shashi
reviewed
Jun 16, 2024
| # Types left off since this is what Dagger does, probably for inference reasons. Not sure if this is the best performance here... | ||
| struct Thunk | ||
| f | ||
| args |
Collaborator
Author
There was a problem hiding this comment.
Yes, all chaining of lazy operations works as on current main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79
This removes use of Daggers lazy API and replaces the execution of lazy trees with Daggers eager API.
Current state is mostly to test the implications of using the eager API.
Adds some very lightweight lazy DAG functionality in the form of Thunk which just stored a function and its arguments. Should probably be replaced with Daggers equivalent if it becomes available.
Some benchmarks based on a modified version of the readme example