feat: add --aggregate flag to allow "du -sh *"-usage#57
Open
LuzianHahn wants to merge 5 commits intosharkdp:masterfrom
Open
feat: add --aggregate flag to allow "du -sh *"-usage#57LuzianHahn wants to merge 5 commits intosharkdp:masterfrom
LuzianHahn wants to merge 5 commits intosharkdp:masterfrom
Conversation
Owner
|
Thank you for working on this.
I think we should at least perform some benchmarks. It's easy to imagine that this will result in a performance regression for some workloads. |
Author
|
Alright, so I found the time to benchmark this. Thanks for your instructions in the README. Made my life a lot easier!
|
before this was triggered when piping into files, but also in pipes in general, which makes things like "grep" difficult
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I found this rather old discussion here and wanted to provide here a solution. Since most people (including me) seem to rather look for a replacement of
du -sh *instead of implicitly aggregating those, I added a functionality, which makes this behavior configurable. The default behavior now considers all provided path-arguments independently.I did not dive into optimizing the workload across different workers, so paths are just worked on sequentially, but while doing so, parallelized.