WiP: defer map library loading #733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
defer-map-scripts
branch
from
40cf1b7 to
c056fa4
Compare
Gnito
force-pushed
the
defer-map-scripts
branch
from
5f2a5de to
2c1e887
Compare
(except SearchPageWithMap and ListingPage). Due to ReusableMapContainer setup, the library should be available app-wide after initial page load (hence just deferring the fetch).
It is used for geocoding (on topbar search), basically on every page. However, only as a reaction to written string on LocationAutocompleteInput.
Gnito
force-pushed
the
defer-map-scripts
branch
from
2c1e887 to
2979f40
Compare
Gnito
force-pushed
the
defer-map-scripts
branch
from
38c4e73 to
ff3bed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: when bounds are coming from URL, the Google Maps is causing an error. (window.google.maps exists, but instances don't match)
Map library is shown on some of the pages, but ReusableMapContainer is used app wide. Because of ReusableMapContainer setup, the library should be available app-wide after initial page load.
However, we can defer the map library loading on pages that don't show the map immediately.
Note: SearchPageWithMap and ListingPage are showing maps by default. If you have customized your client app to show map on some other page, you should add prioritizeMapLibraryLoading: true flag to the route configuration of your custom page.
Steps:
How the defer attribute for script elements behaves:
https://dev.to/fidalmathew/async-vs-defer-in-javascript-which-is-better-26gm