Open
Conversation
edivalentinitu
force-pushed
the
update-version
branch
from
cf86be7 to
1fa793f
Compare
edivalentinitu
changed the title
edivalentinitu
force-pushed
the
update-version
branch
2 times, most recently
from
649f2b3 to
febc785
Compare
mb-wali
reviewed
May 28, 2025
Contributor
There was a problem hiding this comment.
cant we use same .env for both demo and mug?
mb-wali
reviewed
May 28, 2025
demo-compose.yml
Outdated
| - "9200:9200" | ||
| - "9600:9600" | ||
|
|
||
| smarthost: |
Contributor
There was a problem hiding this comment.
we dont need the mail container for this repo, please remove it.
mb-wali
reviewed
May 28, 2025
demo-compose.yml
Outdated
| pull_policy: always | ||
| image: ghcr.io/sharedrdm/instance:main-mug | ||
| env_file: .env.temp | ||
| image: ghcr.io/sharedrdm/instance:v0.13.0-mug |
Contributor
There was a problem hiding this comment.
Suggested change
| image: ghcr.io/sharedrdm/instance:v0.13.0-mug | |
| image: ghcr.io/sharedrdm/instance:${RELEASE_TAG} |
add RELEASE_TAG inside the .env
mb-wali
reviewed
May 28, 2025
demo-compose.yml
Outdated
| - search | ||
| - cache | ||
| - mq | ||
| - smarthost |
Contributor
There was a problem hiding this comment.
Suggested change
| - smarthost |
mb-wali
requested changes
May 28, 2025
Contributor
mb-wali
left a comment
mb-wali
left a comment
There was a problem hiding this comment.
FYI - this repo is just a demo repository that showcases the deployment for MUG.
edivalentinitu
force-pushed
the
update-version
branch
2 times, most recently
from
1d837b1 to
cb309fa
Compare
edivalentinitu
changed the title
edivalentinitu
force-pushed
the
update-version
branch
from
cb309fa to
f18fcb4
Compare
mb-wali
reviewed
May 28, 2025
mug-compose.yml
Outdated
| image: ghcr.io/sharedrdm/instance:main-mug | ||
| image: ghcr.io/sharedrdm/instance:${RELEASE_TAG} | ||
| restart: "unless-stopped" | ||
| env_file: .env.temp |
Contributor
There was a problem hiding this comment.
Suggested change
| env_file: .env.temp | |
| env_file: .env |
and add all the content of .env.temp to .env and have only one env file.
Please enter the commit message for your changes. Lines starting
edivalentinitu
force-pushed
the
update-version
branch
from
f18fcb4 to
ff9a290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.