Conversation
edivalentinitu
force-pushed
the
disable-links
branch
from
2df96b3 to
c727213
Compare
lpandath
reviewed
May 23, 2025
Collaborator
lpandath
left a comment
lpandath
left a comment
There was a problem hiding this comment.
Would suggest using href="#" for unreleased documentation links instead of commenting them out. Because shows planned documentation sections during testing while clearly indicating they are not yet in place.
| </a> | ||
| </div> | ||
| <div class="item"> | ||
| <!-- <div class="item"> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <!-- <div class="item"> | |
| <div class="item"> | |
| <a href="#" title="Reference Guide (Coming soon)" target="_blank"> | |
| {{ _("Reference Guide") }} <i class="download icon"></i> | |
| </a> | |
| </div> |
edivalentinitu
force-pushed
the
disable-links
branch
from
9664a1b to
7b15428
Compare
edivalentinitu
changed the title
lpandath
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.