Skip to content

Conversation

@gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 22, 2025

Description

Web fren of shapeshift/hdwallet#773

Bumps hdwallet packages to pick up Sui Ledger blind signing detection.

Issue (if applicable)

closes #11489

Risk

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low to none - error-handling

Testing

Engineering

  • Ensure without blind signing enabled in Sui Ledger app, you see a toast error prompting you to enable it
  • Ensure Sui transactions work with blind signing enabled

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/2bafcadd-be8d-4917-9c7d-936a5c97a257

Summary by CodeRabbit

  • Chores
    • Updated internal hdwallet dependencies to version 1.62.32 across packages for improved stability and compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Three package.json files across the workspace receive hdwallet package version bumps from 1.62.31 to 1.62.32, specifically updating @shapeshiftoss/hdwallet-core and @shapeshiftoss/hdwallet-ledger dependencies.

Changes

Cohort / File(s) Summary
Hdwallet dependency version bumps
package.json, packages/chain-adapters/package.json, packages/swapper/package.json
Updated @shapeshiftoss/hdwallet-core and @shapeshiftoss/hdwallet-ledger from 1.62.31 to 1.62.32

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple version updates across multiple package.json files with no logic or configuration changes
  • Changes follow a consistent pattern (same dependency versions bumped across multiple locations)

Possibly related PRs

Suggested labels

capy

Suggested reviewers

  • NeOMakinG
  • 0xApotheosis

Poem

🐰 A version bump, so small yet grand,
From thirty-one to thirty-two they stand,
Dependencies dance in harmony true,
The hdwallet hops along with you! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the main objective: adding Sui Ledger blind signing detection, which aligns with the version bumps to hdwallet packages that implement this feature.
Linked Issues check ✅ Passed The PR bumps hdwallet packages to v1.62.32 which includes Sui Ledger blind signing detection implementation, directly addressing issue #11489's requirement to detect blind signing and prompt users appropriately.
Out of Scope Changes check ✅ Passed All changes are scoped to updating hdwallet dependencies across three package.json files to enable Sui Ledger blind signing detection; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gomesalexandre gomesalexandre changed the title feat: Sui Ledger blind signing detection feat: sui Ledger blind signing detection Dec 22, 2025
@gomesalexandre gomesalexandre marked this pull request as ready for review December 22, 2025 11:17
@gomesalexandre gomesalexandre requested a review from a team as a code owner December 22, 2025 11:17
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gomesalexandre gomesalexandre enabled auto-merge (squash) December 24, 2025 14:12
@gomesalexandre gomesalexandre merged commit 04058d0 into develop Dec 24, 2025
4 checks passed
@gomesalexandre gomesalexandre deleted the feat_sui_blind_sign branch December 24, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SUI - blind signing error detection

3 participants