Skip to content

Update example in README#259

Open
NiedziolkaMichal wants to merge 1 commit intoshapesecurity:mainfrom
NiedziolkaMichal:patch-1
Open

Update example in README#259
NiedziolkaMichal wants to merge 1 commit intoshapesecurity:mainfrom
NiedziolkaMichal:patch-1

Conversation

@NiedziolkaMichal
Copy link

Following example doesn't work, because addValue has protected modifier:

policy.sandbox().get().addValue("allow-something-new");

Instead of removing it, it was replaced with usage of SandboxDirective.Value enum, that I've added in #258:

policy.sandbox().get().setValue(SandboxDirective.Value.AllowPopupsToEscapeSandbox, false);

Copy link
Contributor

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, assuming 258 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants