Skip to content

Correct email parsing to prevent malformed tracking links, issue#37#40

Open
iShinzoo wants to merge 2 commits intoshankarpriyank:masterfrom
iShinzoo:master
Open

Correct email parsing to prevent malformed tracking links, issue#37#40
iShinzoo wants to merge 2 commits intoshankarpriyank:masterfrom
iShinzoo:master

Conversation

@iShinzoo
Copy link
Copy Markdown

#issue37 Correct email parsing to prevent malformed tracking links

  • Simplified getTextFromBodyPart function to handle both text/plain and text/html in a single check.
  • Added null checks for bodyPart.body?.data to prevent potential NullPointerExceptions.
  • Simplified email parts handling to concatenate parsed content correctly.
  • Improved regex pattern for capturing Flipkart URLs.
  • Enhanced logging for better debugging information.
  • Added null check for email internalDate to handle missing date cases.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the open-source world 🤓

It is really good to see that you have taken out your precious time to contribute to this project. Communication is very important for open-source,please try to communicate well. Any questions?let me know!

@shankarpriyank
Copy link
Copy Markdown
Owner

hi @iShinzoo thanks for the pr, unfortunately its been quite some time since I last ran this project, so it may take some time for me get the project setup locally again.
Thanks a lot for the pr, I had a quick glance and sadly I feel that the problem mentioned in the issue might still be there.
Meanwhile can you please attach some video clips or screenshots in the pr validating the functionality of the pr?

@iShinzoo
Copy link
Copy Markdown
Author

Hi @shankarpriyank,
I've thoroughly checked all possible components:
-> Base64 Decoding
-> Verified HTML Extraction
-> Improved Regex
Given these checks, I believe the problem should be resolved. However, I'm having issues setting up the OAuth consent screen, so I can't run the application on my local machine or attach video clips.

@shankarpriyank
Copy link
Copy Markdown
Owner

image
Can you please setup the app and test? let me know if I can you help you in any way
I don't think the parsing will be fixed as the new code is just refactored version of the previous code/original code

@iShinzoo
Copy link
Copy Markdown
Author

iShinzoo commented Jun 2, 2024

@shankarpriyank I've encountered issue while setting up the app as per the instructions in the Readme.md file.

Initially, everything seemed to be working fine. However, upon attempting to log in with my tester email ID, I encountered a failure. I meticulously followed the setup process, including setting up a Firebase project and adding the necessary dependencies. Unfortunately, when I added the dependency, I was met with an error that appears to be related to a conflict, as depicted in the screenshot provided here.

To resolve this issue, I've attempted the following:

  • Cleaning and rebuilding the project.
  • Deleting all Gradle cache folders.
  • checked version mismatch

Regrettably, none of these solutions have proven effective. Upon further investigation, I've realized that to build the project successfully, I may need to shift to the latest Kotlin version and Gradle plugin. However, this process seems to introduce complications, as many components in the project become deprecated, making it increasingly intricate to manage.

Could you kindly provide guidance or suggest alternative solutions to address this issue?

@shankarpriyank
Copy link
Copy Markdown
Owner

Umm thanks for all the effort, can you try to revert all the changes in the build.gradle file and then try to build the app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants