Closed
Conversation
Travis encrypted env vars are excluded from PRs so instead we install electron and test locally
Collaborator
Author
|
So Electron won't run on Travis. Duh. And Phantom's the worst. It's implementation of DOM input events is so badly borked that I'm not even sure it's possible to get browser-test-helpers working with it. Oh well. |
Owner
|
Yep this would be cool. Here is a related issue for PR support with sauce labs: travis-ci/travis-core#418 (comment) and a discussion around it: https://support.saucelabs.com/entries/25614798-How-can-we-set-up-an-open-source-account-that-runs-tests-on-people-s-pull-requests- |
Collaborator
Author
|
Whoa, didn't realize that they were working on that. Sweet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis encrypted env vars are excluded from PRs so instead we install electron and test locally