Fix some security issues

[carterbancroft]

No description provided.

[shakefu]

It looks like tests are passing but the Mocha process isn't exiting. Please see if you can figure out how to get the tests to exit properly when they're finished and I'll merge and release.

[carterbancroft]

Thanks Jake, traveling at the moment but I'll get it fixed in the next day or so.

[carterbancroft]

@shakefu what's the trick for running these tests locally? I figured I just needed to have etcd installed locally and have tried both by using homebrew and installing it in a similar way to Travis (via curl -L https://github.com/coreos/etcd/releases/download/v3.3.10/etcd-v3.3.10-darwin-amd64.zip -o etcd-v3.3.10-darwin-amd64.zip).

It times out when creating a new Config instance in the before all hook (https://github.com/shakefu/jetconfig/blob/master/test/index.js#L24).

I can add testing instructions to the README too once I understand them.

[shakefu]

@shakefu what's the trick for running these tests locally? I figured I just needed to have etcd installed locally and have tried both by using homebrew and installing it in a similar way to Travis (via curl -L https://github.com/coreos/etcd/releases/download/v3.3.10/etcd-v3.3.10-darwin-amd64.zip -o etcd-v3.3.10-darwin-amd64.zip).

It times out when creating a new Config instance in the before all hook (https://github.com/shakefu/jetconfig/blob/master/test/index.js#L24).

I can add testing instructions to the README too once I understand them.

I believe I used to run tests against the standard etcd2 docker image, e.g. docker run -d -p $PORT:$PORT etcd:2 but it's been a minute. Also apologies for slow reply @carterbancroft - feel free to ping me on Slack if I'm not responsive.

[shakefu]

@carterbancroft You could probably also reference how the etcd service is spun up in the .travisci if needed. But again I don't know about the etcd2/3 changes. If this is supposed to work against etcd3, you may need to extend .travisci to include an etcd3 test matrix.