Instructs Travis CI to publish to NPM new tags #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed .travis.yml to publish to NPM whenever a new tag is pushed to the repo
minademian
suggested changes
Nov 26, 2018
minademian
left a comment
minademian
left a comment
There was a problem hiding this comment.
Couple of questions:
- Shouldn't the node_js version be higher? When I tried to build with this version on my own PR, it failed to build because it didn't recognize new JS syntax.
- I'm not comfortable with hardcoding api_keys in the repository. Is there a way to conf or retrieve this from a cloud service somehow?
Owner
Author
|
|
Alright cool. I’ll create the separate PR and submit. I’ll hold off on approving until that’s done. |
Owner
Author
|
Perfect. I created an issue for it.
…On Mon, Nov 26, 2018 at 12:45 PM Mina Demian ***@***.***> wrote:
Alright cool. I’ll create the separate PR and submit. I’ll hold off on
approving until that’s done.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnDv8PHenZqgH0Wi7jpFcMThuYopOrtks5uy8ZRgaJpZM4YykUu>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed travis.yml to include publish instructions when new tags are pushed to the repo