Added dropdown features added block print bad files. Updated grammar and other formatting of UI#4
Open
shafiq9018 wants to merge 2 commits intomasterfrom
Open
Conversation
I lost my files accidental deletion.
There was a problem hiding this comment.
Automatic PR Validation failed
There were one or more problems detected with this PR:
- The PR's target branch
masteris not among the allowed target branches: maintenance, devel, staging/bugfix, staging/maintenance, staging/devel. Please only create PRs against these.
Please take a look at the Contribution Guidelines of this repository and make sure that the PR follows them. Thank you!
I'm just a bot 🤖 that does automatic checks, a human will intervene if I've made a mistake.
at line 96 in jinja2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I lost my files accidental deletion.
to a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
develbranch if it's a completelynew feature, or
maintenanceif it's a bug fix or improvement ofexisting functionality for the current stable version (no PRs
against
masteror anything else please)(no PRs from your version of
master,maintenance, ordevelplease), e.g.
dev/my_new_featureorfix/my_bugfixno dead code, ideally only one commit - rebase and squash your PR
if necessary!
.lesssource files, not the.cssfiles (those are generatedwith
lessc)have added unit tests
nothing broke
AUTHORS.mdfile :)What does this PR do and why is it necessary?
How was it tested? How can it be tested by the reviewer?
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes