set prevScale = scale when initializing #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets prevScale to scale in initializeScaling(). Fixes an issue where attach nodes get scaled incorrectly when loading a craft file. (possibly also when loading a vessel in the flight scene?) Issue is caused because prevScale defaults to 1 and through division by prevScale and multiplication by newScale, the node gets moved. This problem has apparently caused wheel instability. (I was not able to repro the instability but other players have and report that this change fixed the problem for them) Will not fix existing craft; craft files must be edited and fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets prevScale to scale in initializeScaling().
Fixes an issue where attach nodes get scaled incorrectly when loading a craft file. (possibly also when loading a vessel in the flight scene?)
Issue is caused because prevScale defaults to 1 and through division by prevScale and multiplication by newScale, the node gets moved. This problem has apparently caused wheel instability. (I was not able to repro the instability but other players have and report that this change fixed the problem for them)
Will not fix existing craft; craft files must be edited and fixed