WIP: Add traits from Path of War: Expanded#94
Open
drumanagh wants to merge 1 commit intoshadowchemosh:masterfrom
drumanagh:add-powe-traits
Open
WIP: Add traits from Path of War: Expanded#94drumanagh wants to merge 1 commit intoshadowchemosh:masterfrom drumanagh:add-powe-traits
drumanagh wants to merge 1 commit intoshadowchemosh:masterfrom
drumanagh:add-powe-traits
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds entries for the four traits in Path of War: Expanded. So far just two of the four, Agile Dancer and Practiced Initiator, are currently implemented (the other two have notes making it clear that right now they're just placeholders).
For Combat Training, I'm not sure how to implement this one, since it's missing a fundamental piece - the text doesn't actually say what the IL of the maneuver it gives is. Would making it basically copy Martial Training's mechanics be a reasonable move? It's extra-weird, though, because it's only separate like that as long as you have no initiating classes, but if you have one it attaches itself to the first one.
For Unorthodox Method, I don't think it would be too difficult to implement, but I'm not sure how to cleanly represent it in the UI, since it needs three choosers (class, discipline to remove, discipline to add), or a Qinggong Monk-style configurable with specials that exist just as choosers.