Add 'double_flags' option -- from Lapin0t #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge https://github.com/sh0oki/begins into test
Conflicts: begin/cmdline.py
This change removed the ability to use 'if begin.start():' so isn't backward compatible: discussion needed before merging. This reverts commit 318db8a.
Adjusted test to expect the non-default flag option to be first. Adjusted help for flag options to only display for non-default option, as per sh0oki's existing code's function.
…tart() returns last return code' (This change removed the ability to use 'if begin.start():' so isn't backward compatible: discussion needed before merging.)
Adjusted test to expect the non-default flag option to be first. Adjusted help for flag options to only display for non-default option, as per sh0oki's existing code's function.
Conflicts: begin/cmdline.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to specify "double_flags=False" to avoid generating flags for the default option. (EG, if default is 'foo=True', it will only generate '--no-foo' option and not the redundant '--foo' option.)
double_flags defaults to True (ie, the same behaviour as before).
This patch also changes the order flag arguments are generated in; the non-default is always generated first (ie '--foo' if default false, '--no-foo' if default true). A test case has been updated to reflect this change.