fix(dflash): use H=1 for BlockMask creation in flex_attention #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes an issue in the DFlash flex_attention implementation where BlockMask was incorrectly created with H=num_head.
Since the mask function dflash_mask_fn(b, h, q_idx, kv_idx) ignores the h parameter, creating separate masks per head is redundant. Using H=1 allows PyTorch to automatically broadcast the mask across all heads
Modifications
Changes
create_block_mask() call
Cleaned up function signature: Removed num_heads parameter from _get_or_create_block_mask()
Related Issues
#452
Accuracy Test
Benchmark & Profiling
Checklist