Skip to content

fix(cmd): use WaitGroup.Go for goroutine creation (Closes #132) #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgaunet merged 1 commit into from
Mar 2, 2026
Merged

fix(cmd): use WaitGroup.Go for goroutine creation (Closes #132) #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions cmd/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,12 +403,10 @@ func handleStreamingResponse(client *perplexity.Client, req *perplexity.Completi
// This prevents memory buildup if rendering is slower than server response generation
responseChannel := make(chan perplexity.CompletionResponse)
var wg sync.WaitGroup
wg.Add(1)

// Start consumer goroutine - must be running before SendSSEHTTPRequest starts producing
// Goroutine lifecycle: spawn -> consume from channel -> defer wg.Done() -> terminate when channel closes
go func() {
defer wg.Done()
// Goroutine lifecycle: spawn -> consume from channel -> terminate when channel closes
wg.Go(func() {
var lastResponse *perplexity.CompletionResponse

if globalOpts.OutputJSON {
Expand Down Expand Up @@ -445,7 +443,7 @@ func handleStreamingResponse(client *perplexity.Client, req *perplexity.Completi
logger.Error("failed to render response", "error", err)
}
}
}()
})

// Producer: sends SSE request, server writes to responseChannel as tokens arrive
// Must happen after goroutine spawn to ensure consumer is ready to receive
Expand Down
Loading