Refactor Certification: separate services, fix UIKit exposure, remove View coordination#17
Open
Refactor Certification: separate services, fix UIKit exposure, remove View coordination#17
Conversation
…or release, remove duplicate build number script Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ve to Presentations/Certification Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
iPhone 17 is only available from Xcode 26.0+. macos-15-arm64 CI runner with Xcode 16.1 only has iPhone 16 series for iOS 18.1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
macos-15-arm64 runner has simulator runtimes from iOS 18.5+. Xcode 16.1 with iOS 18.1 runtime causes xcodebuild timeout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CertificationModalView.swift에 혼재된ComposedImageRenderer→CertificationImageService.swift,ImageSaveHelper+Notification.Name→ImageSaveService.swift로 분리PhotoSelectionViewModel의UIImagePickerController.SourceType공개 노출 제거 →@Published private(set) var selectedSourceType: PhotoSourceType만 노출, UIKit 변환은 View 레이어(View+PhotoSelection)에서 처리View+PhotoSelection에서timerViewModel.reset()직접 호출 제거 →PhotoSelectionViewModel.onCertificationCompleted콜백으로 대체,TimerScreen.handleViewAppear에서 와이어업PhotoSelectionViewMdoel.swift파일명 오타 수정 →PhotoSelectionViewModel.swiftTest plan
fastlane test)🤖 Generated with Claude Code