Implement-get_ca_certs-for-macos#177
Open
BrokenDuck wants to merge 2 commits intosethmlarson:mainfrom
Open
Conversation
|
Pinging @sethmlarson |
sethmlarson
requested changes
Jul 8, 2025
Owner
sethmlarson
left a comment
There was a problem hiding this comment.
I'm not sure I understand the justification in the pull request description:
In order for the get_ca_certs method to work properly on mac os, we need to override the load_defaults_certs method on Mac OS.
I don't think this is correct? get_ca_certs() returns whatever certificates are loaded, in the case of Truststore it's whatever has been loaded manually plus the system certificates. We don't need load_default_certs() implemented for this to work.
Truststore on its own should behave as if load_default_certs() has already been called on all truststore.SSLContext() objects, as the default behavior is to use the system certificates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
On Mac OS, the
load_default_certsSSLContextmethod does not load the system root certificate. In order for theget_ca_certsmethod to work properly on mac os, we need to override theload_defaults_certsmethod on Mac OS.Method
We extract the certificates using the Security Framework, with the
SecTrustCopyAnchorCertificatesfunction. We then load the certificates using theload_verify_locationSSLContextmethod which accepts DER-encoded byte-like certificates in thecadataargument.