Conversation Settings Screen Refactor #645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 27, 2025 09:20
RyanRory
added
enhancement
added 7 commits
December 10, 2025 10:42
mpretty-cyro
requested changes
Dec 18, 2025
| if let qrCodeImage = info.qrCodeImage { | ||
| QRCodeView( | ||
| qrCodeImage: qrCodeImage, | ||
| themeStyle: ThemeManager.currentTheme.interfaceStyle |
Collaborator
There was a problem hiding this comment.
So at the moment the SwiftUI code doesn't actually respond to theme changes (eg. turn on "Auto dark mode" and and toggle the appearance in the simulator while the network screen is visible)
I'm wondering if we need to build out something like the ThemeColorResolver (though with the full theme state included) and pass it as an @Environment so children can just access it directly instead of accessing via ThemeManager.currentTheme (which will get the current state but won't respond to updates)
Collaborator
There was a problem hiding this comment.
Since this PR includes refactoring another screen to use the SwiftUI approach we probably should try to look at resolving it as part of this 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThreadSettingsViewModelSessionListScreen(SwiftUI version `SessionTableViewController)SessionListScreen(SwiftUI)