Skip to content

Null-check hb_language_t before CStr::from_ptr #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrobinson merged 1 commit into from
Feb 17, 2026
Merged

Null-check hb_language_t before CStr::from_ptr #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions harfbuzz/src/language.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ impl Language {
/// assert_eq!(lang.to_string(), "en-us");
/// ```
pub fn to_string(&self) -> &str {
// Since we panic if we have a non-UTF-8 language tag,
// we might as well panic on an invalid language tag,
// which is possible if allocation failed within HarfBuzz
// itself.
assert!(self.is_valid());
unsafe { core::ffi::CStr::from_ptr(sys::hb_language_to_string(self.raw)) }
.to_str()
.unwrap()
Expand Down
Loading