bindgen now outputs f32 instead of c_float.#150
Closed
waywardmonkeys wants to merge 1 commit intoservo:masterfrom
Closed
bindgen now outputs f32 instead of c_float.#150waywardmonkeys wants to merge 1 commit intoservo:masterfrom
waywardmonkeys wants to merge 1 commit intoservo:masterfrom
Conversation
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 13fc2b4 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
May 28, 2019
bindgen now outputs f32 instead of c_float. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/150) <!-- Reviewable:end -->
Contributor
|
💔 Test failed - checks-travis |
Collaborator
Author
|
I'll look at those failures. |
Collaborator
Author
|
Submitted a fix to |
Collaborator
Author
|
It ends up that they argue that this is a bug in bindgen and so this change shouldn't land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is