Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ classifiers = [
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
]
dependencies = [
"pyclack-cli[prompts]==0.4.0",
"asyncclick==8.3.0.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these, the idea of excluding all pip modules if for security reasons, it ensures that the user/consumer chooses the amount of risk they want to expose themselves to. very important in an enterprise environment!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but without these the CLI may not work. The user has to explicitly install these for it to work. If that is fine then i will remove them in here and add them to requirements.txt for the unit tests for work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, i wonder then if we need to bundle this as a separate pip module then, enterprise environments aren't usually happy with dependency changes, it clobbers up their SBOM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, do you think we could do something like servc[cli]. And the cli can be installed separately with, decoupled from core svc logic

pip install servc[cli]

"anyio==4.11.0"
]

[build-system]
requires = ["setuptools>=61.0"]
Expand All @@ -26,6 +31,9 @@ build-backend = "setuptools.build_meta"
Repository = "https://github.com/serv-c/servc-python.git"
Documentation = "https://docs.servc.io/"

[project.scripts]
servc = "servc.cli:cli"

[tool.semantic_release]
assets = []
commit_message = "{version}\n\nAutomatically generated by python-semantic-release"
Expand Down
23 changes: 23 additions & 0 deletions servc/__main__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/usr/bin/env python3
"""
Main entry point for the servc CLI when run as a module.
This allows the package to be executed with: python -m servc
"""

import asyncio
from servc.cli import cli, click


def main():
"""Main entry point for the CLI."""
try:
asyncio.run(cli())
except KeyboardInterrupt:
click.secho("Operation cancelled.", fg="red")
except Exception as e:
click.secho(f"{e}", fg="red")
raise


if __name__ == "__main__":
main()
21 changes: 21 additions & 0 deletions servc/cli/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@

import asyncclick as click

from servc.cli.config import config
from servc.cli.commands import init


@click.group()
@config
async def cli(ctx):
"""servc CLI - A tool for servc services.

Create and manage servc projects.

Common commands:

init Initialize a new servc project
"""
pass

cli.add_command(init)
1 change: 1 addition & 0 deletions servc/cli/commands/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from servc.cli.commands.init import cli as init
1 change: 1 addition & 0 deletions servc/cli/commands/init/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from servc.cli.commands.init.src import cli
Loading
Loading