-
Notifications
You must be signed in to change notification settings - Fork 1
feat(cli): added cli support for project initialization #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| Main entry point for the servc CLI when run as a module. | ||
| This allows the package to be executed with: python -m servc | ||
| """ | ||
|
|
||
| import asyncio | ||
| from servc.cli import cli, click | ||
|
|
||
|
|
||
| def main(): | ||
| """Main entry point for the CLI.""" | ||
| try: | ||
| asyncio.run(cli()) | ||
| except KeyboardInterrupt: | ||
| click.secho("Operation cancelled.", fg="red") | ||
| except Exception as e: | ||
| click.secho(f"{e}", fg="red") | ||
| raise | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
|
|
||
| import asyncclick as click | ||
|
|
||
| from servc.cli.config import config | ||
| from servc.cli.commands import init | ||
|
|
||
|
|
||
| @click.group() | ||
| @config | ||
| async def cli(ctx): | ||
| """servc CLI - A tool for servc services. | ||
|
|
||
| Create and manage servc projects. | ||
|
|
||
| Common commands: | ||
|
|
||
| init Initialize a new servc project | ||
| """ | ||
| pass | ||
|
|
||
| cli.add_command(init) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from servc.cli.commands.init import cli as init |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from servc.cli.commands.init.src import cli |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove these, the idea of excluding all pip modules if for security reasons, it ensures that the user/consumer chooses the amount of risk they want to expose themselves to. very important in an enterprise environment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but without these the CLI may not work. The user has to explicitly install these for it to work. If that is fine then i will remove them in here and add them to requirements.txt for the unit tests for work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, i wonder then if we need to bundle this as a separate pip module then, enterprise environments aren't usually happy with dependency changes, it clobbers up their SBOM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, do you think we could do something like
servc[cli]. And the cli can be installed separately with, decoupled from core svc logic