-
-
Notifications
You must be signed in to change notification settings - Fork 10
fix ready deprecation #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a deprecation warning in discord.js by replacing the deprecated ready event with the new clientReady event name using the Events.ClientReady enum. It also updates the discord.js dependency to version 14.22.1 to support the new event naming.
- Updates event listener from string literal "ready" to
Events.ClientReadyenum - Bumps discord.js dependency to version 14.22.1
- Applies code formatting improvements throughout the ready handler
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/handlers/ready.ts | Updates deprecated ready event to clientReady using Events enum and applies code formatting |
| package.json | Bumps discord.js dependency from 14.14.1 to 14.22.1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SrIzan10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SrIzan10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you should bump the package version through here
|
looks good to me |
DuroCodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated and bumped
fixes the deprecation warning
Warning
this also bumps discord.js to
^14.22.1, but there shouldn't be any breaking changes.