Skip to content

Conversation

@hejtful
Copy link
Contributor

@hejtful hejtful commented Feb 7, 2025

Linear: EDTR-98
API (db-migrations) PR: serlo/api.serlo.org#1865
Infra PR: serlo/infra#120

Should only be merged once the DB migration has been run on staging.

@vercel
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Feb 18, 2025 5:16pm

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 105.37 KB (-8 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 106.7 KB (🟢 -14 B) 212.06 KB
/___bot_or_not 114.84 KB (-2 B) 220.2 KB
/___content 4.16 KB (🟢 -19 B) 109.53 KB
/___editor_preview 201.96 KB (🟡 +12 B) 307.32 KB
/biologie 175.24 KB (🟢 -27 B) 280.6 KB
/chemie 175.23 KB (🟢 -27 B) 280.6 KB
/content-only/[...slug] 95.7 KB (🟡 +6 B) 201.06 KB
/discussions 93.93 KB (🟡 +1 B) 199.3 KB
/entity/create/[type]/[taxonomyId] 223.7 KB (🟡 +212 B) 329.06 KB
/entity/license/update/[id] 63.41 KB (🟡 +8.49 KB) 168.78 KB
/entity/repository/add-revision/[...id] 223.36 KB (🟡 +208 B) 328.73 KB
/entity/repository/compare/[entity_id]/[revision_id] 111.61 KB (🟢 -27 B) 216.97 KB
/entity/repository/history/[id] 67.76 KB (🟢 -16 B) 173.13 KB
/event/history 124.47 KB (-1 B) 229.83 KB
/event/history/[...slug] 125.45 KB (-1 B) 230.82 KB
/event/history/user/profile/[username] 127.83 KB (-1 B) 233.2 KB
/gleichungs-app 162.19 KB (🟡 +2 B) 267.55 KB
/informatik 175.24 KB (🟢 -27 B) 280.6 KB
/lerntipps 175.24 KB (🟢 -27 B) 280.6 KB
/license/detail/[id] 82.81 KB (-7 B) 188.18 KB
/mathe 175.23 KB (🟢 -27 B) 280.6 KB
/nachhaltigkeit 175.24 KB (🟢 -27 B) 280.61 KB
/page/create 223.37 KB (🟡 +213 B) 328.73 KB
/pages 56.22 KB (🟢 -20 B) 161.59 KB
/taxonomy/term/create/[parent_id]/[id] 223.07 KB (🟡 +214 B) 328.44 KB
/user/notifications 126.7 KB (-1 B) 232.07 KB
/user/profile/[username] 194.08 KB (🟢 -29 B) 299.45 KB
/user/settings 225.1 KB (🟡 +157 B) 330.47 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@hejtful hejtful marked this pull request as ready for review February 10, 2025 13:26
Copy link
Member

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some parts that I don't understand, but to me it looks fine. Let me know if I should look into something specific in more detail.

@hejtful hejtful marked this pull request as draft February 11, 2025 15:37
refactor(editor+web): remove fields from template plugins in editor
refactor(editor): try replacing entityType with normal object
@hejtful hejtful marked this pull request as ready for review February 18, 2025 17:13
@hejtful hejtful merged commit fd04f9f into staging Feb 18, 2025
8 checks passed
@hejtful hejtful deleted the refactor/adjust-frontent-to-new-editor-storage-format branch February 18, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants