Skip to content

update modules#143

Open
wormen wants to merge 4 commits intosergeyksv:masterfrom
wormen:master
Open

update modules#143
wormen wants to merge 4 commits intosergeyksv:masterfrom
wormen:master

Conversation

@wormen
Copy link

@wormen wormen commented Jan 15, 2017

No description provided.

Added events / alternative for PubSub

// Hook-like
collection.on('save', function(doc) { }) // Will be called before saving a document - no matter if using save, insert or update methods. You can modify the document in this event, it's essentially a hook

// After operation is complete
collection.on('saved', function(docs) { }) // Called after inserting or updating documents is complete; docs is an array of documents
collection.on('removed', function(ids) { }) // Called after removing documents is complete; ids is an array of ids
@anhoev
Copy link

anhoev commented Mar 13, 2018

Hi, does the pull request make tingo use new mongodb driver 2.xx ?

@wormen
Copy link
Author

wormen commented Mar 13, 2018

@anhoev at the time of this writing, yes of course

@anhoev
Copy link

anhoev commented Mar 13, 2018

I see, but it did not pass the test ?

@wormen
Copy link
Author

wormen commented Mar 13, 2018

@anhoev
the author does not pass 95% of tests
all that was all the modified code works correctly

@anhoev
Copy link

anhoev commented Mar 13, 2018

@sergeyksv this pull request is very important . Why do you not accept it ?
There are mongodb driver 3.x now and tingo is out of date.
I want to use tingo with mongoose 4.x for my project . Can you evaluate the pull request ?

@ex1st
Copy link
Contributor

ex1st commented Mar 13, 2018

@anhoev tingodb don't use the mongodb driver. It's dev dependency for a compatibility test.
Please check #166 Thank you.

@wormen
Copy link
Author

wormen commented Mar 13, 2018

@anhoev now, this project is easier to rewrite to ES6, than to adapt it to new versions of modules

@ex1st
Copy link
Contributor

ex1st commented Mar 13, 2018

@wormen you're right, I think @sergeyksv is open to pull requests.

@anhoev
Copy link

anhoev commented Mar 13, 2018

@wormen Can you make tungus work with mongoose 4.x ?

@anhoev
Copy link

anhoev commented Mar 13, 2018

@ex1st : i see , thanks you .

@wormen
Copy link
Author

wormen commented Mar 13, 2018

@anhoev then better 5.x

@anhoev
Copy link

anhoev commented Mar 13, 2018

@wormen i see , 5.x will be better . Can you send me your skype or email to my email : info@star-kasse.de.

@wormen
Copy link
Author

wormen commented Mar 13, 2018

@anhoev sended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants