Conversation
irisqul
reviewed
Dec 18, 2025
task_1.py
Outdated
| total = [] | ||
|
|
||
| for i in self.__name_items: | ||
| total.append(self.__name_items[i]) |
There was a problem hiding this comment.
TypeError: list indices must be integers or slices, not str - там нет цен чтобы их добавлять, нужно посмотреть в другом словаре
| return self.twenty_percent_tax_calculation() + self.ten_percent_tax_calculation() | ||
|
|
||
| @staticmethod | ||
| def get_telephone_number(telephone_number): |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| if len(total) > 10: | ||
| return sum(total) * 0.9 * 0.1 | ||
| else: | ||
| return sum(total) * 0.1 |
There was a problem hiding this comment.
пожалуйста проверь подсчеты налогов, неверно считает
| return f'+7{telephone_number}' | ||
|
|
||
| @staticmethod | ||
| def get_date_and_time(): |
irisqul
reviewed
Dec 19, 2025
task_1.py
Outdated
| if not isinstance(telephone_number, int): | ||
| raise ValueError('Необходимо ввести цифры') | ||
|
|
||
| if len(telephone_number) > 10: |
There was a problem hiding this comment.
Для типа int не существует этого метода. Чтобы узнать длину телефона - нужно перевести тип в str и тогда можно будет применить метод len
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.