Changed all the s3 key string formatting to use path #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of filepath, to remove unnecessary OS prefixes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 81.25% 81.88% +0.63%
==========================================
Files 5 5
Lines 416 414 -2
==========================================
+ Hits 338 339 +1
+ Misses 47 45 -2
+ Partials 31 30 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
at-wat
reviewed
Jan 5, 2026
Member
at-wat
left a comment
at-wat
left a comment
There was a problem hiding this comment.
Thank you for the PR!
Added a comment and otherwise looks good
Co-authored-by: Atsushi Watanabe <atsushi.w@ieee.org>
at-wat
approved these changes
Jan 13, 2026
Member
at-wat
left a comment
at-wat
left a comment
There was a problem hiding this comment.
LGTM
Sorry for the delay and thank you for your contribution!
at-wat
changed the title
at-wat
reviewed
Jan 13, 2026
Member
at-wat
left a comment
at-wat
left a comment
There was a problem hiding this comment.
Some comments seems accidentally removed
Member
|
Let me restore the comments and merge |
at-wat
pushed a commit
that referenced
this pull request
Jan 13, 2026
Fix s3 path handling on Windows
at-wat
added a commit
that referenced
this pull request
Jan 13, 2026
Fix s3 path handling on Windows Backports: #448 Co-authored-by: Francisco Almeida <franciscoalm100@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all the s3 key string formatting to use path.join instead of filepath, to remove unnecessary OS prefixes