Conversation
Other changes: - city.is_empty method added - assert_fields when searching cities fixed - workaround for cyclic import (wip)
Fix MaxThread option being ignored. Remove unused legacy_ssl parameter.
Add some more type hints
Try to address several issues we have, as follows: - DRY principle - more documentation (docstrings, type-hints) - less `try..except` clutter and error silencing - more logging - unused variables removed - avoid RuntimeError while iterating+deleting items from a container - use SO_REUSEADDR to address some (not all) TIME_WAIT issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on top of #138, this PR refactors the network code, most of the reasoning is described in the commit description. It should solve most (not all) network issues we have. I mainly tried to solved the following ones:
This refactoring will also allow to deduplicate the open-beta central_server code.
Ready to be reviewed & tested.