fix(assembly): add DNA/RNA support to to_fasta method#16
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 82.88% 82.58% -0.31%
==========================================
Files 14 14
Lines 1648 1654 +6
Branches 226 229 +3
==========================================
Hits 1366 1366
- Misses 221 227 +6
Partials 61 61
🚀 New features to boost your workflow:
|
jnooree
previously approved these changes
Feb 20, 2026
9fb02ed to
33d96b8
Compare
jnooree
approved these changes
Feb 20, 2026
Contributor
Author
|
@jnooree 이것도 test 짜야 하나용?! |
Member
|
짜면 좋긴 한데 워낙 단순해서.. 걍 합쳐도 될거같슴다 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
casp data 만들 때 assembly.to_fasta() method 쓰는데
DNA, RNA 지원 안 되어서 추가합니다!
Checklist
If the change is related to the source code, tests, or build environments, please also check the following:
pytest -vspass without any errors and warnings (at the project root)?mypy --prettypass without any errors and warnings (at the project root)?If you added new feature(s), then also check the following:
Linked Issues
Link the tracking issue(s) of this PR, with the auto-close keywords here:
Note
Low Risk
Small, localized change to sequence export plus additive tests/fixtures; low risk aside from potential edge cases in residue ID mapping for nucleic acids.
Overview
Assembly.to_fasta()now generates FASTA output for all polymer chains (Protein,DNA,RNA) instead of protein-only, using newdna_restype_3to1/rna_restype_3to1mappings (defaulting unknown bases toN) while preserving proteinmodreshandling.Adds pytest coverage for protein/DNA/RNA FASTA generation and introduces new mmCIF/CCD test fixtures (notably
tests/test_data/mmcif/1bna.cifand additional nucleotide components incomponents_stdres.cif) to support the new cases.Written by Cursor Bugbot for commit 9fb02ed. This will update automatically on new commits. Configure here.