fix(data/mmcif/smiles): don't select bond partner as StereoAtom#14
Merged
fix(data/mmcif/smiles): don't select bond partner as StereoAtom#14
StereoAtom#14Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 13. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 82.91% 82.79% -0.12%
==========================================
Files 14 14
Lines 1580 1587 +7
Branches 206 207 +1
==========================================
+ Hits 1310 1314 +4
- Misses 217 219 +2
- Partials 53 54 +1
🚀 New features to boost your workflow:
|
StereoAtom
jnooree
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt neighbors
Checklist
If the change is related to the source code, tests, or build environments, please also check the following:
pytest -vspass without any errors and warnings (at the project root)?mypy --prettypass without any errors and warnings (at the project root)?If you added new feature(s), then also check the following:
Linked Issues
Link the tracking issue(s) of this PR, with the auto-close keywords here:
Covalent 리간드이면서 공유결합 부분 때문에 말단 이중결합이 생기면, 여기서 (
Chem.AssignStereochemistry(mol, force=True)) 그냥 넘어가고,Chem.AssignCIPLabels(mol, chiral_atoms, configured_bonds)에서 segfault 되는 것 같습니다.gmol-base/src/gmol/base/data/mmcif/smiles.py
Lines 82 to 109 in 31dd926