Skip to content

tests: fix mlflow_manager import mocking on Python 3.12 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nguyenhuulocbb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tests: fix mlflow_manager import mocking on Python 3.12 #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/unit/test_mlflow_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
"""Tests for MLflow manager."""

import builtins
import pytest
from src.roma_dspy.config.schemas.observability import MLflowConfig
from src.roma_dspy.core.observability import MLflowManager

_real_import = builtins.__import__

def test_mlflow_config_defaults():
"""Test MLflow config defaults."""
Expand Down Expand Up @@ -46,8 +46,10 @@ def test_mlflow_manager_enabled_no_mlflow_package(monkeypatch):
# Mock import error
def mock_import(name, *args, **kwargs):
if name == "mlflow":
raise ImportError("No module named 'mlflow'")
return __builtins__.__import__(name, *args, **kwargs)
# Giữ logic cũ: giả vờ mlflow không cài
raise ImportError("mlflow not installed")
# Dùng bản backup từ builtins thay vì __builtins__
return _real_import(name, *args, **kwargs)

monkeypatch.setattr("builtins.__import__", mock_import)

Expand Down