This repository was archived by the owner on Jan 7, 2020. It is now read-only.
Open
Conversation
Current coverage is 22.79% (diff: 10.76%)@@ master #623 diff @@
==========================================
Files 26 25 -1
Lines 1972 2009 +37
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 454 458 +4
- Misses 1463 1496 +33
Partials 55 55
|
b51d438 to
6b697d2
Compare
Contributor
|
Thank you @suhussai for this PR, I really appreciate it! The only problem I see so far with the logrus package is the fact that there's no way, out of the box, to identify the Remote Caller (see sirupsen/logrus#63) but it's an issue with the package itself, not your implementation. Removing that capability would make debugging much more harder, so we'll have to think of a workaround before merging this change. I'll look around, let me know if you find something! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the logger package and related tests.
Related Issue
#615
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Example logs with logrus:

Types of changes
Checklist: