Conversation
|
Sorry I don't know if Binstubs are needed... Let me know if there's anything else you'd like me to change to get this merged. Thanks. |
|
Ping! I think this is a useful PR... I am using a fork of it from here and it's working well: Anything else I can do to help get this merged @majormoses? 🙇 |
majormoses
left a comment
majormoses
left a comment
There was a problem hiding this comment.
LGTM
I would like a second pair of eyes on this one since I am less familiar with bonsai setup.
|
@tylermauthe could you take a look at the .bonsai.yaml file in #64 and update this PR to include it? It has more build targets and it makes use of platform_family to provide better filtering. |
Build breaks when added.
|
@nixwiz - when I added that, the build broke However, I have reverted my changes to the original and it seems the build is still broken. Is master building correctly? Has a new test been added? Note: I haven't even looked at the error output - but I do notice that all recent builds on PRs are failing. |
|
the failure is the version of bundler being installed in travis differs from what is specified in the gemspec: We probably want to specify in the travis file to install/upgrade (a specific version) of bundler before attempting to |
| services: | ||
| - docker | ||
| cache: | ||
| - bundler |
There was a problem hiding this comment.
Add the following lines here to help fix Travis build
before_install:
- gem install bundler
nixwiz
left a comment
nixwiz
left a comment
There was a problem hiding this comment.
After updating .travis.yml, also update the bundler dependency in the gemspecl to '~> 2.1' and add these changes to the CHANGELOG.
3 participants
Pull Request Checklist
Adding Bonzai the same way it was done for this PR:
sensu-plugins/sensu-plugins-network-checks#94
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Known Compatibility Issues