test: add unit tests for OptionResolver#62
Open
MaxwellCalkin wants to merge 3 commits intosensay-io:mainfrom
Open
test: add unit tests for OptionResolver#62MaxwellCalkin wants to merge 3 commits intosensay-io:mainfrom
MaxwellCalkin wants to merge 3 commits intosensay-io:mainfrom
Conversation
Creates a reusable OptionResolver class that handles the standard configuration priority chain (CLI → ENV → Interactive → Project → User) as specified in CLAUDE.md. Adds global --silent/-s option that skips interactive prompts and uses config defaults. Refactors chat and simple-organization-setup commands to use OptionResolver, eliminating duplicated config resolution logic. Closes sensay-io#2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…roject config When --save is passed, options resolved via interactive prompts that aren't already in the project config are saved to sensay.config.json after resolution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
18 tests covering priority chain, silent mode, interactive mode, save option behavior, and config loading. Validates the complete resolution logic introduced in the OptionResolver class. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptionResolverutility classTest plan
npx jest tests/option-resolver.test.ts🤖 Generated with Claude Code