This repository was archived by the owner on Apr 2, 2022. It is now read-only.
Changing LIKE queries to ILIKE to allow for case insensitive searching#12
Open
knightpfhor wants to merge 1 commit intosendgrid:masterfrom
Open
Changing LIKE queries to ILIKE to allow for case insensitive searching#12knightpfhor wants to merge 1 commit intosendgrid:masterfrom
knightpfhor wants to merge 1 commit intosendgrid:masterfrom
Conversation
|
ILIKE is not specific to postgres I'm pretty sure. And email itself is also supposed to be case insensitive. It might be better to specifically downcase all emails in the query, and create an index on it |
|
Either way searches shouldn't be case sensitive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been caught out while copy/pasting email addresses and additional arguments not finding results because the source had a different case to how it had been passed to SendGrid in the first place. Using ILIKE instead of LIKE seems to solve the problem (even if it is unique to POSTGRESQL, I'm not sure if that's a problem for this project or not)