feat: Add timezone parameter to get_hist() - Issue #72 #8
+1,737
−1,324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses GitHub issue rongardF#72 by allowing users to specify the timezone for the datetime index in the returned DataFrame. Changes: - Add `timezone` parameter to get_hist() method - Add _get_timezone_object() helper function for timezone resolution - Modify __create_df() to convert timestamps to specified timezone - Support both zoneinfo (Python 3.9+) and pytz as fallback - Add TV_TIMEZONE environment variable support - Maintain backward compatibility (no timezone = local system time) Timezone priority: parameter > TV_TIMEZONE env var > local system Examples: - timezone='UTC' returns UTC timestamps - timezone='America/New_York' returns EST/EDT timestamps - No timezone = local system time (backward compatible) Tests: Added 15 new tests in TestTimezoneFeature class - Timezone object creation tests - Conversion accuracy tests (UTC, EST) - Environment variable priority tests - Invalid timezone error tests Documentation updated in README.md and CLAUDE.md
semoi
deleted the
claude/add-timeframe-parameter-01LRVJAbqPS6sgaWdRvSerKq
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses GitHub issue rongardF#72 by allowing users to specify the timezone for the datetime index in the returned DataFrame.
Changes:
timezoneparameter to get_hist() methodTimezone priority: parameter > TV_TIMEZONE env var > local system
Examples:
Tests: Added 15 new tests in TestTimezoneFeature class
Documentation updated in README.md and CLAUDE.md