Add bounds to base in Haskell template
#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cabal check` fails if bounds are missing, so this is needed for `validate-template` to succeed on Haskell. If these bounds turn out to be incorrect downstream (for example, after unsupported GHC versions are removed), it will be discovered by CI anyway. Unfortunately, this isn’t enough to get `cabal check` passing. It will also need to have core/src/ created, which requires sellout/flaky#183.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cabal checkfails if bounds are missing, so this is needed forvalidate-templateto succeed on Haskell. If these bounds turn out to be incorrect downstream (for example, after unsupported GHC versions are removed), it will be discovered by CI anyway.Unfortunately, this isn’t enough to get
cabal checkpassing. It will also need to have core/src/ created, which requires sellout/flaky#183.