Extract flake outputs to a separate file #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outputs are the only part of the flake that are actually a Nix expression[^1]. This makes it easier to deal with that by pulling `outputs` into an actual Nix file. [^1]: Even that isn’t quite true – `outputs` isn’t an arbitrary function, but must syntactically have a single argument. That is, we can’t η-reduce `outputs` to get rid of the `inputs` argument. This also helps with reducing templating – because flake.nix isn’t a Nix expression and since Project Manager runs from the flake, flake.nix _must_ be part of the template. Extracting outputs makes it easier to see what can actually be removed, and reduces conflicts in flake.nix when the template is updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outputs are the only part of the flake that are actually a Nix expression1. This makes it easier to deal with that by pulling
outputsinto an actual Nix file.This also helps with reducing templating – because flake.nix isn’t a Nix expression and since Project Manager runs from the flake, flake.nix must be part of the template. Extracting outputs makes it easier to see what can actually be removed, and reduces conflicts in flake.nix when the template is updated.
Footnotes
Even that isn’t quite true –
outputsisn’t an arbitrary function, but must syntactically have a single argument. That is, we can’t η-reduceoutputsto get rid of theinputsargument. ↩