Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NA/NaNas threshold arguments to length/comparison assertions by surfacing clear assertion errors.Description
assert_length*()variants solength = NA/NaNreturns"'length' must not be missing"rather than causingmissing value where TRUE/FALSE needed(changes inR/assert_length.R).validate_minimum,validate_maximum, andvalidate_between_thresholdssmall validators and wired them into comparison assertion chains (assert_all_*andassert_between/assert_all_between) to validateminimum,maximum, andinclusivebefore comparisons (changes inR/assert_compare.R).is_whole_number()to return a strict logical scalar and treat missing/non-finite/non-scalar values asFALSE(change inR/is_functions.R).length,minimum,maximum, and updatedis_whole_number()expectations (changes intests/testthat/), and updatedNEWS.mdto document the user-visible behavior fix.Testing
devtools::document()successfully to update docs.devtools::test()and all tests passed after fixes (final test run reported all tests passing).devtools::check(); package build and checks executed butR CMD checkreported one warning about missing systemqpdfand one note about time verification, causingdevtools::check()to exit with a non-zero status due to the warning; the code changes themselves did not produce R errors during checks.devtools::load_all()forassert_length(..., NaN),assert_greater_than(..., NaN), andassert_between(..., maximum = NaN)which returned the new informative assertion messages as expected.Codex Task