fix: preserve underscores in fault entity_id#56
Merged
mfaferek93 merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
transformFault() was replacing underscores with hyphens in entity_id (e.g., tank_process -> tank-process). This broke fault detail fetching because the actual SOVD entity ID uses underscores. Remove the replace(/_/g, '-') call. ROS 2 node names use underscores and gateway SOVD IDs preserve them. Fixes #55
There was a problem hiding this comment.
Pull request overview
Fixes incorrect fault entity_id normalization in the frontend transform layer so faults with underscores in their reporting source correctly map to SOVD entity IDs (preventing 404s when fetching fault details/environment snapshots).
Changes:
- Updated
transformFault()to preserve underscores inentity_idextracted fromreporting_sources. - Updated unit tests to assert underscore-preserving behavior and adjusted test descriptions accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/lib/transforms.ts |
Stops converting underscores to hyphens when deriving entity_id from reporting_sources. |
src/lib/transforms.test.ts |
Updates expectations and test name to validate underscore preservation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transformFault()was replacing underscores with hyphens in entity_id extracted fromreporting_sources. This broke fault detail fetching - FaultsPanel called e.g.GET /apps/tank-process/faults/...instead of/apps/tank_process/faults/..., getting 404.Changes
src/lib/transforms.ts: removenodeName.replace(/_/g, '-')src/lib/transforms.test.ts: update expectations to preserve underscoresTest plan
Fixes #55