Merged
Conversation
Hatchling does not follow symlinks outside the package directory, so _generated/ was missing from the built wheel. Replace ln -sf with cp -r to include generated API and model code in the wheel. Closes #11
bburda
force-pushed
the
fix/wheel-include-generated
branch
from
f5c5a70 to
e4d4a2b
Compare
There was a problem hiding this comment.
Pull request overview
Fixes Python wheel packaging by ensuring generated client code is physically included in the package directory (avoiding hatchling’s behavior of not following symlinks that point outside the package).
Changes:
- Replaces the
_generatedsymlink creation with arm -rf && cp -rcopy step in CI. - Applies the same fix to both
build-and-testandpublishjobs to keep behavior consistent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mfaferek93
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The published wheel was missing
_generated/because hatchling doesn't follow symlinks outside the package directory. Replaceln -sfwithcp -rin both CI jobs so generated code is physically present before building.Issue
Type
Testing
cp -r generated src/ros2_medkit_client/_generatedinstead of symlinkbuild-and-testandpublishjobsChecklist