fix(ci): publish Python wheel to GitHub Releases#10
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Python client CI workflow to prevent publish failures on GitHub Packages and adds a PR-only guard to ensure pyproject.toml’s version is bumped beyond the latest published package version.
Changes:
- Added a
version-checkjob on pull requests to validate strictMAJOR.MINOR.PATCHand enforce a monotonic version bump vs. the latest published package. - Removed the unsupported
--skip-existingflag fromtwine uploadwhen publishing to GitHub Packages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
da12b85 to
2d53ddf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GitHub Packages does not support PyPI registry, so twine upload with --skip-existing always failed. Replace with gh release create that uploads the built wheel as a GitHub Release asset. Install via: pip install https://github.com/selfpatch/ros2_medkit_clients/releases/download/py-v0.1.0/ros2_medkit_client-0.1.0-py3-none-any.whl Removes broken version-check job and twine dependency. Closes #9
2d53ddf to
b5d61cb
Compare
mfaferek93
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
GitHub Packages does not support PyPI registry - twine upload always failed with
UnsupportedConfiguration. Replace withgh release createthat uploads the built wheel as a GitHub Release asset.Install via:
Changes:
--skip-existingflagversion-checkjob (relied on non-existent PyPI registry)gh release createwith wheel upload, taggedpy-v{version}Issue
Type
Testing
build-and-testjob unchangedpublishjob: builds wheel, reads version from pyproject.toml, creates GitHub Release with tagpy-v{version}, uploads .whlChecklist