Skip to content

fix(ci): publish Python wheel to GitHub Releases#10

Merged
bburda merged 1 commit intomainfrom
fix/python-publish-skip-existing
Mar 30, 2026
Merged

fix(ci): publish Python wheel to GitHub Releases#10
bburda merged 1 commit intomainfrom
fix/python-publish-skip-existing

Conversation

@bburda
Copy link
Copy Markdown
Contributor

@bburda bburda commented Mar 30, 2026

Pull Request

Summary

GitHub Packages does not support PyPI registry - twine upload always failed with UnsupportedConfiguration. Replace with gh release create that uploads the built wheel as a GitHub Release asset.

Install via:

pip install https://github.com/selfpatch/ros2_medkit_clients/releases/download/py-v0.1.0/ros2_medkit_client-0.1.0-py3-none-any.whl

Changes:

  • Remove twine and broken --skip-existing flag
  • Remove broken version-check job (relied on non-existent PyPI registry)
  • Add gh release create with wheel upload, tagged py-v{version}
  • Release notes include install command

Issue


Type

  • Bug fix
  • New feature or tests
  • Breaking change
  • Documentation only

Testing

  • build-and-test job unchanged
  • publish job: builds wheel, reads version from pyproject.toml, creates GitHub Release with tag py-v{version}, uploads .whl
  • Overwrites existing release if same version is re-published

Checklist

  • Breaking changes are clearly described (and announced in docs / changelog if needed)
  • Tests were added or updated if needed
  • Docs were updated if behavior or public API changed

Copilot AI review requested due to automatic review settings March 30, 2026 10:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Python client CI workflow to prevent publish failures on GitHub Packages and adds a PR-only guard to ensure pyproject.toml’s version is bumped beyond the latest published package version.

Changes:

  • Added a version-check job on pull requests to validate strict MAJOR.MINOR.PATCH and enforce a monotonic version bump vs. the latest published package.
  • Removed the unsupported --skip-existing flag from twine upload when publishing to GitHub Packages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bburda bburda force-pushed the fix/python-publish-skip-existing branch from da12b85 to 2d53ddf Compare March 30, 2026 11:04
@bburda bburda changed the title fix(ci): replace --skip-existing with semver version check fix(ci): publish Python wheel to GitHub Releases Mar 30, 2026
@bburda bburda self-assigned this Mar 30, 2026
@bburda bburda requested review from Copilot and mfaferek93 March 30, 2026 11:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GitHub Packages does not support PyPI registry, so twine upload with
--skip-existing always failed. Replace with gh release create that
uploads the built wheel as a GitHub Release asset.

Install via:
  pip install https://github.com/selfpatch/ros2_medkit_clients/releases/download/py-v0.1.0/ros2_medkit_client-0.1.0-py3-none-any.whl

Removes broken version-check job and twine dependency.

Closes #9
@bburda bburda force-pushed the fix/python-publish-skip-existing branch from 2d53ddf to b5d61cb Compare March 30, 2026 11:15
@bburda bburda merged commit a06b96d into main Mar 30, 2026
4 checks passed
@bburda bburda deleted the fix/python-publish-skip-existing branch March 30, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Python publish fails: twine --skip-existing unsupported by GitHub Packages

3 participants