fix: printer does not update TX/RX pin #810
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fixes an issue where the printer TX/RX pin is not updated correctly after changing the configuration.
Steps to reproduce
Settings > Hardware > Printer > Driverand set it tothermal/adafruit.Then go to
Thermal > TX Pin, set it to39, go back, and save the settings.Tools > Device Tests > Print Test QRand confirm “Print as QR?”.(Nothing happens, as the pin is invalid.)
Settings > Hardware > Printer > Thermal > TX Pin, set it to35, go back, and save the settings.Tools > Device Tests > Print Test QRand confirm “Print as QR?”.(An error occurs.)
Error
Result
After this PR, the error no longer occurs and the printer works correctly when following the same steps.
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?