Skip to content

Conversation

@tadeubas
Copy link
Member

What is this PR for?

As @kdmukai pointed out on Krux chat, when doing things fast, as in workshops for example, "Are you sure?" prompts doesn't help much. This PR adds a little context to those prompts that exit actions.

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

Did you build the code and tested on device?

  • Yes, build and tested on embed_fire

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (b748413) to head (0e7af92).

Files with missing lines Patch % Lines
src/krux/pages/__init__.py 33.33% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (71.42%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #806      +/-   ##
===========================================
- Coverage    97.38%   97.37%   -0.01%     
===========================================
  Files           83       83              
  Lines        10548    10549       +1     
===========================================
  Hits         10272    10272              
- Misses         276      277       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant