Skip to content

Conversation

@tadeubas
Copy link
Member

@tadeubas tadeubas commented Dec 11, 2025

What is this PR for?

  • Adds a new battery percentage indicator that updates approximately every 5 seconds

Note: In rare cases, such as when the user briefly connects and disconnects the charger with a low battery, the displayed value may be inaccurate for about a minute. Most of the time, the feature works as expected.

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

Did you build the code and tested on device?

  • Yes, build and tested on Amigo, Cube, M5StickV

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

@tadeubas tadeubas force-pushed the new-battery-percent branch from 6f00b50 to e280454 Compare December 11, 2025 12:51
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.30%. Comparing base (b748413) to head (54ed2d6).

Files with missing lines Patch % Lines
src/krux/pages/__init__.py 10.00% 9 Missing ⚠️
src/krux/input.py 80.00% 2 Missing ⚠️
src/krux/krux_settings.py 77.77% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (55.17%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #805      +/-   ##
===========================================
- Coverage    97.38%   97.30%   -0.09%     
===========================================
  Files           83       83              
  Lines        10548    10565      +17     
===========================================
+ Hits         10272    10280       +8     
- Misses         276      285       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@qlrd qlrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i will test here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants