Skip to content

[Refactor] Human-friendly splash definition #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kdmukai wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

[Refactor] Human-friendly splash definition #765

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7954343
Reformat and simplify the `SPLASH`
kdmukai Nov 11, 2025
5037084
Remove constant used for upcoming screensaver PR.
kdmukai Nov 11, 2025
e789709
remove f-string
kdmukai Nov 11, 2025
3b385bd
More standard(?) formatting syntax
kdmukai Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/krux/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,22 @@

ASIAN_MIN_CODEPOINT = 12288

# Splash will use horizontally-centered text plots. Uses Thin spaces to help with alignment
SPLASH = [
"██" + THIN_SPACE * 3,
"██" + THIN_SPACE * 3,
"██" + THIN_SPACE * 3,
"██████" + THIN_SPACE * 3,
"██" + THIN_SPACE * 3,
THIN_SPACE + "██" + THIN_SPACE * 2 + "██",
"██" + THIN_SPACE + "██",
"████" + THIN_SPACE,
"██" + THIN_SPACE + "██",
THIN_SPACE + "██" + THIN_SPACE * 2 + "██",
THIN_SPACE * 2 + "██" + THIN_SPACE * 3 + "██",
]
human_friendly_splash = """
Copy link
Member

@qlrd qlrd Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will throw an warning on pylint:

src/krux/display.py:55:0: C0103: Constant name "human_friendly_splash" doesn't conform to UPPER_CASE naming style (invalid-name)
Suggested change
human_friendly_splash = """
SPLASH = """

██
██
██
██████
██
██ ██
██ ██
████
██ ██
██ ██
██ ██
"""
# Reformat as a list of strings w/fixed length padding to preserve the shape
# when it's rendered as horizontally centered individual lines.
SPLASH = ["{:<9}".format(row) for row in human_friendly_splash.split("\n") if row != '']
Copy link
Member

@qlrd qlrd Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SPLASH = ["{:<9}".format(row) for row in human_friendly_splash.split("\n") if row != '']
SPLASH = ["{:<9}".format(row) for row in SPLASH.split("\n") if row != '']



class Display:
Expand Down
Loading