Add seictl binary to seid container
#2673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
The `seictl` utility is used extensively in the new infrastructure. Not having it would mean custom baking images which ultimately results in drift from test what we actually ship. Add it to the image as an "all in one" image. Its size is small enough to not matter for performance and portability.
masih
force-pushed
the
masih/seictl-dockerfile
branch
from
247f3d9 to
113d694
Compare
sei-will
approved these changes
Jan 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
=======================================
Coverage 43.81% 43.81%
=======================================
Files 1908 1908
Lines 159047 159047
=======================================
+ Hits 69679 69694 +15
+ Misses 82959 82950 -9
+ Partials 6409 6403 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
codchen
approved these changes
Jan 8, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
The `seictl` utility is used extensively in the new infrastructure. Not having it would mean custom baking images which ultimately results in drift from test what we actually ship. Add it to the image as an "all in one" image. Its size is small enough to not matter for performance and portability. (cherry picked from commit 4107264)
|
Successfully created backport PR for |
masih
pushed a commit
that referenced
this pull request
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
seictlutility is used extensively in the new infrastructure. Not having it would mean custom baking images which ultimately results in drift from test what we actually ship.Add it to the image as an "all in one" image. Its size is small enough to not matter for performance and portability.