Skip to content

Conversation

@arajasek
Copy link
Contributor

@arajasek arajasek commented Jan 6, 2026

Describe your changes and provide context

As a result, validators using this mempool logic will produce blocks with a batch of EVM txs, followed by any non-EVM txs. This will allow us to use future executors that can only run EVM txs to run a bigger batch of EVM txs, falling back to existing executors for all non-EVM and interop behaviour.

Note that:

  • this PR is NOT consensus-breaking. this is only a mempool operation, not a change to the rules of the protocol.
  • this PR does NOT change which txs the mempool reaps. the exact same txs are selected as before, just ordered to be a contiguous slab of EVM txs, followed by a slab of non-EVM ones.

Testing performed to validate your change

Added a new test, all tests pass

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 8, 2026, 2:39 PM

return append(evmTxs, nonEvmTxs...)
}

// ReapMaxTxs returns a list of transactions within the provided number of
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the ReapMaxTxs method's behaviour is not changed by this PR, since that method is used for RPC etc. support (and not for block creation).

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.82%. Comparing base (4107264) to head (b791d79).

Files with missing lines Patch % Lines
sei-tendermint/internal/mempool/mempool.go 91.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
+ Coverage   43.79%   43.82%   +0.02%     
==========================================
  Files        1908     1908              
  Lines      159047   159053       +6     
==========================================
+ Hits        69659    69706      +47     
+ Misses      82981    82939      -42     
- Partials     6407     6408       +1     
Flag Coverage Δ
sei-chain 45.89% <ø> (ø)
sei-cosmos 38.20% <ø> (ø)
sei-db 69.13% <ø> (ø)
sei-tendermint 47.33% <91.66%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/mempool/mempool.go 68.11% <91.66%> (+0.33%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sei-will sei-will self-requested a review January 7, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants