-
Notifications
You must be signed in to change notification settings - Fork 859
feat: mempool: return all EVM txs before others when reaping #2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
| return append(evmTxs, nonEvmTxs...) | ||
| } | ||
|
|
||
| // ReapMaxTxs returns a list of transactions within the provided number of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the ReapMaxTxs method's behaviour is not changed by this PR, since that method is used for RPC etc. support (and not for block creation).
97bebe8 to
a899316
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
==========================================
+ Coverage 43.79% 43.82% +0.02%
==========================================
Files 1908 1908
Lines 159047 159053 +6
==========================================
+ Hits 69659 69706 +47
+ Misses 82981 82939 -42
- Partials 6407 6408 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
a899316 to
b791d79
Compare
Describe your changes and provide context
As a result, validators using this mempool logic will produce blocks with a batch of EVM txs, followed by any non-EVM txs. This will allow us to use future executors that can only run EVM txs to run a bigger batch of EVM txs, falling back to existing executors for all non-EVM and interop behaviour.
Note that:
Testing performed to validate your change
Added a new test, all tests pass